fix: v9 Option hover and pressed tokens #28592
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 588 | 616 | 5000 | |
| Button | mount | 287 | 297 | 5000 | |
| Field | mount | 1078 | 1055 | 5000 | |
| FluentProvider | mount | 648 | 645 | 5000 | |
| FluentProviderWithTheme | mount | 77 | 85 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 67 | 64 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 72 | 75 | 10 | |
| InfoButton | mount | 13 | 12 | 5000 | |
| MakeStyles | mount | 847 | 855 | 50000 | |
| Persona | mount | 1649 | 1565 | 5000 | |
| SpinButton | mount | 1304 | 1340 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 06c689c:
|
📊 Bundle size report
Unchanged fixtures
|
fabricteam
reviewed
Jul 20, 2023
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵 fluentuiv9 Open the Visual Regressions report to inspect the affected screenshots
Combobox Converged 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Combobox Converged.Disabled option.active option.chromium.png | 53 | Changed |
| Combobox Converged.Disabled option.hover.chromium.png | 53 | Changed |
There was a problem hiding this comment.
Seems like you need to ensure that these colors are properly overriden when an Option is disabled.
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 14804fe31e9f34d3f21998dcb386fdddd23f9839 (build) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds explicit tokens for react-combobox Option hover & pressed states. This does not change the Web light/dark theme, but does affect Teams high contrast, and potentially other themes that use separate hover/pressed foreground tokens.
Fixes #28225